Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callback for Location #128

Closed
wants to merge 1 commit into from

Conversation

komitake
Copy link
Contributor

This pull request may resolve #122

didChangeAuthorization is called twice when the CLLocationManager instance is created and authorization status is changed. The mechanism handled by requestedLocation and triggerCallbacks is based on this behavior.
So CLLocationManager instance must be created at the time of requesting authorization.

@komitake
Copy link
Contributor Author

komitake commented Dec 4, 2020

The original issue is that the callback does not get called when selecting Only While Using the App option on iOS 12.
However, after iOS 13, the options are changed to Allow While Using App and Allow Once.

Now I can say there are no problems on iOS 13. The callback gets called when selecting both Allow While Using App and Allow Once.
So let me close this pull request.

@komitake komitake closed this Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LocationAlways callback when selecting locationWhenInUse
1 participant